Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add appropriately named action to unpublish #166

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Add appropriately named action to unpublish #166

merged 1 commit into from
Oct 22, 2019

Conversation

jonathan-s
Copy link
Contributor

This adds an appropriately named action to add an item that is suitable to be unpublished.

This was referenced Oct 15, 2019
Closed
Closed
Closed
@jonathan-s jonathan-s mentioned this pull request Oct 21, 2019
Merged
Aiky30
Aiky30 requested changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@Aiky30 Aiky30 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change not part of #161 ?

@jonathan-s
Copy link
Contributor Author

It's not part of #161 for three reasons.

  • It is basically a naming change for the user to understand that this is an item that should be added to a collection for the purpose of unpublishing.
  • This is specifically used by 3rd party packages only. There is no code that uses this internally in moderation.
  • Smaller PRs are better PRs ;)

Though I can understand the case for having that included in 161 too.

@Aiky30 Aiky30 merged commit ef2bd3e into django-cms:release/1.0.x Oct 22, 2019
@jonathan-s
Copy link
Contributor Author

jonathan-s commented Oct 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiky30 Aiky30 Aiky30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathan-s @Aiky30